[pvrusb2] wrong default values

[Mike Isely]

Problem found and fixed.  It was a stupid logic error - that dated all 
the way back to April 2006!  After roughly August 2008, a bug was 
introduced that produced garbage default data for non-integer (e.g. 
enumeration) controls.  Prior to that point, the same mistake caused 
this value to always be zero, but still wrong.

I will push the changes soon.

  -Mike


On Mon, 30 Mar 2009, Mike Isely wrote:

> 
> Never mind my previous response.  I didn't look far enough.  I see the 
> cx2341x defaults you are talking about and will investigate.  This 
> should be an easy fix.  I am not sure how this escaped notice for so 
> long; some other factor must be involved.
> 
>   -Mike
> 
> 
> On Mon, 30 Mar 2009, Martin Dauskardt wrote:
> 
> > When I check v4l2-ctl --list-ctrls-menu after loading pvrusb2 I get a lot of 
> > negative values (see attachment)
> > Tested with the v4l-dvb hg from today, but the problem exists longer.
> > 
> > For the pvrinput vdr-plugin, we are currently detecting the default value by 
> > using struct v4l2_queryctrl . Unless the user does not set other values, 
> > those detected values are used for initialising the card. Now we 
> > get "Numerical result out of range" errors.
> > 
> > I think it is not a cx2341x problem, because the ivtv driver delivers the 
> > right default values.
> > 
> > Mike, can you fix it?
> > 
> > 
> 
> 

-- 

Mike Isely
isely @ pobox (dot) com
PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8