[pvrusb2] [patch] capture window centering via VIDIOC_S_CROP

[Mike Isely]

On Sat, 10 May 2008, Mark Goldberg wrote:

> On Sat, May 10, 2008 at 9:12 PM, roger <roger at eskimo.com> wrote:
> > Mark, it just occurred to me this is probably more of a question should be asked within your distro's support forum (ie. IRC, Web Board Forums, etc).
> >
> > I don't use RedHat/Fedora and I think Mike uses Debian.
> >
> > Also note, pvrusb2 is now included within the kernel now.  (Older
> > versions were released as patches -- six months to a year now since
> > pvrusb2 was included w/i the kernel?)
> >
> > I don't know if anybody is going to have any better advice here on this
> > one.  ... besides correcting my data, lol.
> 
> I found this:
> 
> http://www.linlap.com/wiki/Installing+the+latest+V4L+TV+tuner+drivers+for+Fedora+8
> 
> Basically getting v4l-dvb from Mercurial, building and replacing the
> modules. Looks reasonably
> easy.

Yes, and in fact this is the way to get the "in-V4L" version of the 
pvrusb2 driver.  At this moment both the standalone driver and this 
version are pretty much in-sync.  (However I haven't done anything to 
merge this cropping change yet.)

The cx25840 part of the patch, by the way, needs to go into the v4l-dvb 
repository.  Once there, it will find its way into the kernel tree the 
next time a merge window opens (which won't be now until after 2.6.26 is 
released).


> 
> It might be better to start from the Fedora Kernel source though.  If
> I can get the kernel source set up
> correctly, it looks as simple as Make M=<path to module>. The problem
> is to get the kernel source
> set up with the right things so it thinks it is for the existing
> kernel, not a new copy you want to build.
> 
> I guess I'l have to try both and see which works after Mike comes up
> with some patches for NTSC.
> 
> Please post them and let us know which versions of which sources they
> are against.

I am in the middle of some unrelated work right now.  Once I get some 
breathing room from that, I'm going to look at these patches.  Some 
things I need to examine:

1. I need to understand what is going on inside of the cx25840 module so 
that I can get it reviewed.  This is likely something that Hans Verkuil 
will want to examine.

2. I need to test for NTSC and examine a few related issues.

3. I also want to see if I can make corresponding changes to the saa7115 
module so that 29xxx devices will be able to support this feature.

  -Mike


-- 

Mike Isely
isely @ pobox (dot) com
PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8