[pvrusb2] initialization of video_gop_size

Dan Bodoh dan.bodoh at gmail.com
Sun Jun 22 12:44:39 CDT 2008


I've just submitted a bug to mythtv
(http://svn.mythtv.org/trac/ticket/5462) regarding the display of the
recording length of the show.  I'm not sure if this is a mythtv bug, a
pvrusb2 bug, a cx2341x bug, or some combination.

It appears that cx2341x initializes the video_gop_size to 12, and it
is never changed by the kernel version of pvrusb2 or mythtv (unless
its changed by the user).

I've inspected pvrusb2-mci-20080210/driver/pvrusb2-encoder.c.  There's
two different pvr2_encoder_configure() selected by the macro
PVR2_ENABLE_CX2341XMOD.    When the macro *is not* defined, pvrusb2
sets the video_gop_size based to 15 for NTSC, and 12 otherwise.  If
the macro *is* defined, the video_gop_size is not explicitly set, so
the cx2341x module's default of 12 is in force.

Should pvrusb2-encoder.c be setting this value to 15 for NTSC?  Is 12
a legal value for NTSC?  Or should the default be set correctly in the
cx2341x module?

It appears the ivtv driver for my old pvr-350 set it correctly to 15.

Dan Bodoh


More information about the pvrusb2 mailing list