[pvrusb2] 2.6.16 rc4 git 9 compile error

[Mike Isely]

On Tue, 28 Feb 2006, Frans Meulenbroeks wrote:

> Xavier, I did not build this kernel myself, but got it
> from the archive for my system. Hence the source dir
> 2.6.15
>
> I've dug some more into this and found the root cause.
> (but not the solution)
>
> pvrusb includes include/media/v4l2-common.h
> this one declares struct msp_matrix
>
> However my tree contains two files msp3400.h
> -rw-rw-r--  1 slug slug 773 Jan  3 04:21
> ./linux-2.6.15/.pc/2.6.16-rc4/drivers/media/video/msp3400.h
> -rw-rw-r--  1 slug slug 3180 Feb 28 22:21
> ./linux-2.6.15/drivers/media/video/msp3400.h
>
> The first one seems to be the one that is included (no
> idea how/why). However that one also includes
> msp_matrix.
>
> No idea what causes this.
>
> Best regards, Frans.

I just checked my 2.6.16-rc1 tree and the only definition for that struct 
is in v4l2-common.h.  Now, with that said obviously you're using -rc4 here 
instead of -rc1 so perhaps there's been a change.  Also I know with older 
kernels v4l2-common.h did not exist and in fact the struct in question was 
indeed in msp3400.h hidden in the source (as opposed to the header) area.

Four possibilities:

1. You patched up to -rc4 and the old header didn't get patched or 
removed.

2. You're somehow patching in an old ivtv snap which would have an 
msp3400.h.

3. Somehow you copied ivtv/msp3400.h from the pvrusb2 snapshot into the 
kernel tree (don't do that - it is only for the drivers *in* that 
directory in the snapshot).

4. There's real breakage in -rc4.

I don't know what else to suggest.

   -Mike

-- 
                         |         Mike Isely          |     PGP fingerprint
      Spammers Die!!     |                             | 03 54 43 4D 75 E5 CC 92
                         |   isely @ pobox (dot) com   | 71 16 01 E2 B5 F5 C1 E8
                         |                             |